Re: [PATCH v3 3/3] i2c: i2c-qcom-geni: Simplify irq handler

[alokc]

On 2018-09-26 03:19, Doug Anderson wrote:
> Hi,
>
> On Mon, Sep 24, 2018 at 4:52 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> 
> wrote:
> > We don't need to use goto here, we can just collapse the if statement
> > and goto chain into multiple branches and then combine some duplicate
> > completion calls into one big if statement. Let's do it to clean up 
> > code
> > some more.
> >
> > Cc: Karthikeyan Ramasubramanian <kramasub@xxxxxxxxxxxxxx>
> > Cc: Sagar Dharia <sdharia@xxxxxxxxxxxxxx>
> > Cc: Girish Mahadevan <girishm@xxxxxxxxxxxxxx>
> > Cc: Doug Anderson <dianders@xxxxxxxxxxxx>
> > Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> > ---
> >  drivers/i2c/busses/i2c-qcom-geni.c | 70 
> > +++++++++++++-----------------
> >  1 file changed, 29 insertions(+), 41 deletions(-)
>
> It doesn't gleam as powerfully the cleanups in patch 2/3 but this does
> have a few nice readability improvements.
>
> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

agree.

Reviewed-by: Alok Chauhan <alokc@xxxxxxxxxxxxxx>

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,a Linux Foundation Collaborative Project