Re: [PATCH V14 2/2] scsi: ufs: Add configfs support for UFS provisioning

[Sayali Lokhande]

On 9/24/2018 3:33 PM, Avri Altman wrote:
> > obj-$(CONFIG_SCSI_UFS_QCOM) += ufs-qcom.o
> > obj-$(CONFIG_SCSI_UFSHCD) += ufshcd-core.o
> > ufshcd-core-objs := ufshcd.o ufs-sysfs.o
> > +obj-$(CONFIG_SCSI_UFS_PROVISION) += ufs-configfs.o
> Isn't ufs-configfs should be part of ufshcd-core? like ufs-sysfs ?
Agree. Will update.
> > +static ssize_t ufs_config_desc_show(struct config_item *item, char *buf,
> > +                                   u8 index)
> > +{
> The read part already exist in ufs-sysfs.
User can just read the existing desc here and update the required fields 
as per need and write updated buffer to same configfs path.
I think its better to have both r/w functionality here.
> > +ssize_t ufshcd_desc_configfs_store(struct config_item *item, const char *buf,
> > +                                  size_t count, u8 index)
> > +{
>
> > +
> > +       /*
> > +        * First read the current configuration descriptor
> > +        * and then update with user provided parameters
> > +        */
> if originally only lun0 was configured, and you want to configure a new set of luns -
> luns 8 to 15 (config index 0x1) - won't the read fail in that case?
Let me try it out on my setup internally and update once I test this 
scenario
> Thanks,
> Avri