Re: [RESEND PATCHv2] misc: cxl: Fix possible null pointer dereference

[Frederic Barrat]

Le 04/10/2018 Ã 07:02, zhong jiang a ÃcritÂ:
> It is not safe to dereference an object before a null test. It is
> not needed and just remove them. Ftrace can be used instead.
>
> Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx>
> ---

Acked-by: Frederic Barrat <fbarrat@xxxxxxxxxxxxx>


>   drivers/misc/cxl/guest.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
> index 3bc0c15..5d28d9e 100644
> --- a/drivers/misc/cxl/guest.c
> +++ b/drivers/misc/cxl/guest.c
> @@ -1018,8 +1018,6 @@ int cxl_guest_init_afu(struct cxl *adapter, int slice, struct device_node *afu_n
>
>   void cxl_guest_remove_afu(struct cxl_afu *afu)
>   {
> -	pr_devel("in %s - AFU(%d)\n", __func__, afu->slice);
> -
>   	if (!afu)
>   		return;