Re: [PATCH 2/3] staging: rtl8188eu: cleanup array declaration - style

From: Michael Straube
Date: Thu Oct 04 2018 - 08:12:09 EST


On 10/3/18 11:30 PM, Joe Perches wrote:
static struct mlme_handler mlme_sta_tbl[] = {

Perhaps const here too, and as well, the struct
declaration could use const char * instead of char *


Making it const gives following warning.

drivers/staging/rtl8188eu/core/rtw_mlme_ext.c: In function 'mgt_dispatcher':
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4114:9: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
ptable = mlme_sta_tbl;
^

So I'll only change the char * to const char *.
Thanks.