Re: [PATCH v2 4/5] locking/lockdep: Make class->ops a percpu counter

[Waiman Long]

On 10/04/2018 06:14 AM, Ingo Molnar wrote:
> * Waiman Long <longman@xxxxxxxxxx> wrote:
>
>> diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h
>> index b0d0b51c4d85..1fd82ff99c65 100644
>> --- a/include/linux/lockdep.h
>> +++ b/include/linux/lockdep.h
>> @@ -99,13 +99,8 @@ struct lock_class {
>>  	 */
>>  	unsigned int			version;
>>  
>> -	/*
>> -	 * Statistics counter:
>> -	 */
>> -	unsigned long			ops;
>> -
>> -	const char			*name;
>>  	int				name_version;
>> +	const char			*name;
> 'name' gets moved by the patch - better structure packing on 64-bit kernels?
>
> Looks good to me otherwise.
>
> Thanks,
>
> 	Ingo

Yes, that is done on purpose to pack the 2 integers together to remove
two 4-byte holes on 64-bit archs.

Cheers,
Longman