Re: [PATCH net-next] udp: Add tracepoints to monitor skbs going in and out of a UDP socket

From: David Howells
Date: Thu Oct 04 2018 - 13:01:56 EST


David Ahern <dsahern@xxxxxxxxx> wrote:

> These do not add any real value. You are only dumping the skb address,

Not in and of themselves, no - but in combination with tracepoints elsewhere,
where you can use the skb address as a key to follow the lifetime of a
particular skb.

> and you can get the same effect with a probe on the function and dumping
> the value of the register with the skb argument.

Installing a probe requires various preconditions, including your kernel not
being locked down and having the source around AIUI.

Anyway, I've no especially strong feelings about this patch - it's been useful
for me and it might be useful to others.

David