Re: [PATCH v9 3/3]: perf record: extend trace writing to multi AIO

[Alexey Budankov]

Hi,

On 05.10.2018 10:22, Namhyung Kim wrote:
> On Wed, Oct 03, 2018 at 07:17:01PM +0300, Alexey Budankov wrote:
<SNIP>
>> @@ -1833,6 +1861,10 @@ static struct option __record_options[] = {
>>  			  "signal"),
>>  	OPT_BOOLEAN(0, "dry-run", &dry_run,
>>  		    "Parse options then exit"),
>> +#ifdef HAVE_AIO_SUPPORT
>> +	OPT_INTEGER(0, "aio-cblocks", &record.opts.nr_cblocks,
>> +		    "Max number of simultaneous per-mmap trace writes (default: 0 - serial, max: 4)"),
>> +#endif
>>  	OPT_END()
>>  };
> 
> Please update the documentation for the new option and config

Accepted.

> variable.  Perhaps it can provide the option always and check the
> availability at runtime (with a warning message if not enabled).

Not sure if this complication is really required. 
So far NO_AIO define is possible at compile time.

Thanks,
Alexey