Re: [PATCH] iommu/amd: Clear memory encryption mask from physical address
From: Joerg Roedel
Date: Fri Oct 05 2018 - 04:31:06 EST
On Thu, Oct 04, 2018 at 09:40:23PM +0000, Singh, Brijesh wrote:
> Boris Ostrovsky reported a memory leak with device passthrough when SME
> is active.
>
> The VFIO driver uses iommu_iova_to_phys() to get the physical address for
> an iova. This physical address is later passed into vfio_unmap_unpin() to
> unpin the memory. The vfio_unmap_unpin() uses pfn_valid() before unpinning
> the memory. The pfn_valid() check was failing because encryption mask was
> part of the physical address returned. This resulted in the memory not
> being unpinned and therefore leaked after the guest terminates.
>
> The memory encryption mask must be cleared from the physical address in
> iommu_iova_to_phys().
Merged and on its way upstream, thanks Brijesh.