Re: [PATCH v10 10/10] mtd: maps: gpio-addr-flash: Add support for device-tree devices
From: Boris Brezillon
Date: Fri Oct 05 2018 - 08:11:03 EST
On Fri, 5 Oct 2018 14:04:52 +0200
Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx> wrote:
> Hi Boris
> On Fri, Oct 5, 2018 at 12:12 PM Boris Brezillon
> <boris.brezillon@xxxxxxxxxxx> wrote:
> >
> > On Fri, 5 Oct 2018 11:54:18 +0200
> > Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx> wrote:
> >
> > > Hi Boris
> > >
> > > Just seen that you already did the rebase at
> > > https://github.com/bbrezillon/linux-0day/commits/mtd/physmap-cleanup
> > >
> > > Thanks for that.
> > >
> > > I am about to test it in real hw (unless you want me wait)
> >
> > Sure, go ahead and test it.
> >
> > Thanks,
> >
> > Boris
> I had to change this on your patchset to have it working on hw:
> https://pastebin.com/78A7yhJ9
>
> If you send the patchset to the mailing list I can review it patch by patch.
>
> Also
> mtd: maps: Prepare merging of physmap and physmap_of
>
> I do not think that can be bisected. (Not sure, I have to test it)
Okay, I'll have a look.
>
> I add the diff to the mail, but gmail will probably scramble the
> lines(yes I know I have to use other mail client)
The diff looks good, I'll fix that an send a push a new version.
Thanks,
Boris