Re: [PATCH] i2c: core: squelch error: uninitialized symbol 'ret'

From: George G. Davis
Date: Fri Oct 05 2018 - 16:55:36 EST


On Fri, Oct 05, 2018 at 07:43:01PM +0200, Wolfram Sang wrote:
>
> > Feel free to ignore if this is a topic already discussed in other
> > threads. To be honest, I did not search the mailing list to determine if
> > this particular issue was already discussed.
>
> Not this particular issue, but in general we usually don't change
> working code to silence false positives in code checkers.

Ok.

> But thanks for letting me know this is a false positive!

No worries. Thanks for having a look.

> BTW next time CC Dan Carpenter, he might be interested to fix the issue
> in smatch.

I'll try to remember this in the future.

Thanks again!

--
Regards,
George