Re: [PATCH net v2] net: mvpp2: Extract the correct ethtype from the skb for tx csum offload

[David Miller]

From: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>
Date: Fri,  5 Oct 2018 09:04:40 +0200

> When offloading the L3 and L4 csum computation on TX, we need to extract
> the l3_proto from the ethtype, independently of the presence of a vlan
> tag.
> 
> The actual driver uses skb->protocol as-is, resulting in packets with
> the wrong L4 checksum being sent when there's a vlan tag in the packet
> header and checksum offloading is enabled.
> 
> This commit makes use of vlan_protocol_get() to get the correct ethtype
> regardless the presence of a vlan tag.
> 
> Fixes: 3f518509dedc ("ethernet: Add new driver for Marvell Armada 375 network unit")
> Signed-off-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>
> ---
> V2: Use htons on values that can be swapped at compile-time, following
>     Yan's comment. Fix the "Fixes" tag and a typo, following Sergei's comment.

Applied and queued up for -stable.