Re: [PATCH v9 1/3] [media] imx214: device tree binding

[Sakari Ailus]

On Sat, Oct 06, 2018 at 12:18:28AM +0200, Ricardo Ribalda Delgado wrote:
> Hi Sakari
> On Sat, Oct 6, 2018 at 12:02 AM Sakari Ailus <sakari.ailus@xxxxxx> wrote:
> >
> > Hi Ricardo,
> >
> > On Fri, Oct 05, 2018 at 11:57:50PM +0200, Ricardo Ribalda Delgado wrote:
> > > Document bindings for imx214 camera sensor
> > >
> > > Cc: devicetree@xxxxxxxxxxxxxxx
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > > Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx>
> > > ---
> > > Changelog from v8:
> > >
> > > Rob Herring:
> > > -rename file
> > > -Move address to reg
> > > -rename name on example
> > > -Patch author
> > >
> > > Sakari Ailus:
> > > -should->shall
> > >
> > >  .../bindings/media/i2c/sony,imx214.txt        | 53 +++++++++++++++++++
> > >  1 file changed, 53 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx214.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx214.txt b/Documentation/devicetree/bindings/media/i2c/sony,imx214.txt
> > > new file mode 100644
> > > index 000000000000..2744773070c5
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx214.txt
> > > @@ -0,0 +1,53 @@
> > > +* Sony 1/3.06-Inch 13.13Mp CMOS Digital Image Sensor
> > > +
> > > +The Sony imx214 is a 1/3.06-inch CMOS active pixel digital image sensor with
> > > +an active array size of 4224H x 3200V. It is programmable through an I2C
> > > +interface.
> > > +Image data is sent through MIPI CSI-2, through 2 or 4 lanes at a maximum
> > > +throughput of 1.2Gbps/lane.
> > > +
> > > +
> > > +Required Properties:
> > > +- compatible: Shall be "sony,imx214".
> > > +- reg: I2C bus address of the device. Depending on how the sensor is wired,
> > > +       it shall be <0x10> or <0x1a>;
> > > +- enable-gpios: GPIO descriptor for the enable pin.
> > > +- vdddo-supply: Chip digital IO regulator (1.8V).
> > > +- vdda-supply: Chip analog regulator (2.7V).
> > > +- vddd-supply: Chip digital core regulator (1.12V).
> > > +- clocks: Reference to the xclk clock.
> > > +- clock-names:  Shall be "xclk".
> >
> > It could be that this was already discussed earlier but I missed that ---
> > clock frequency. Apologies for that. How does the driver know what to ask?
> > If you expect assigned-clock-rate or such, then I think it should be
> > explicitly said here.
> 
> It has becoming hard to follow, it is mainly my fault for sending 10 series :)
> 
> I think we discussed this here:
> https://lkml.org/lkml/2018/10/2/1402

Right. The driver uses 24 MHz for now, but that's not a property of the
sensor. If the driver only supports 24 MHz now, then it should check that
the frequency it gets matches with that. If other frequencies are needed
in the future, the driver would be amended with that support.

As I noted earlier, a lot of drivers set the frequency based on the
clock-frequency property (as documented in bindings) and never check the
outcome. I guess using assigned-clock-rate would yield the same result.

I think I'd put clock-frequency property here, and document it as
mandatory.

> 
> 
> >
> > You also have a single clock, so do you need clock-names?
> 
> Seems to be the de-facto standard Looking at:
> grep xclk Documentation/devicetree/bindings/media/i2c/*
> 
> But the driver does not look for a specific name. I am going to remove the name.
> 
> >
> > > +
> > > +Optional Properties:
> > > +- flash-leds: See ../video-interfaces.txt
> > > +- lens-focus: See ../video-interfaces.txt
> > > +
> > > +The imx214 device node shall contain one 'port' child node with
> > > +an 'endpoint' subnode. For further reading on port node refer to
> > > +Documentation/devicetree/bindings/media/video-interfaces.txt.
> > > +
> > > +Required Properties on endpoint:
> > > +- data-lanes: check ../video-interfaces.txt
> > > +- link-frequencies: check ../video-interfaces.txt
> > > +- remote-endpoint: check ../video-interfaces.txt
> > > +
> > > +Example:
> > > +
> > > +     camera-sensor@1a {
> > > +             compatible = "sony,imx214";
> > > +             reg = <0x1a>;
> > > +             vdddo-supply = <&pm8994_lvs1>;
> > > +             vddd-supply = <&camera_vddd_1v12>;
> > > +             vdda-supply = <&pm8994_l17>;
> > > +             lens-focus = <&ad5820>;
> > > +             enable-gpios = <&msmgpio 25 GPIO_ACTIVE_HIGH>;
> > > +             clocks = <&mmcc CAMSS_MCLK0_CLK>;
> > > +             clock-names = "xclk";
> > > +             port {
> > > +                     imx214_ep: endpoint {
> > > +                             data-lanes = <1 2 3 4>;
> > > +                             link-frequencies = /bits/ 64 <480000000>;
> > > +                             remote-endpoint = <&csiphy0_ep>;
> > > +                     };
> > > +             };
> > > +     };
> > > --
> > > 2.19.0
> > >
> >
> > --
> > Sakari Ailus
> > e-mail: sakari.ailus@xxxxxx
> 
> 
> 
> -- 
> Ricardo Ribalda

-- 
Sakari Ailus
e-mail: sakari.ailus@xxxxxx