Re: [PATCH 0/3] x86/mm/doc: Clean up mm.txt

From: Ingo Molnar
Date: Sat Oct 06 2018 - 08:22:05 EST



* Baoquan He <bhe@xxxxxxxxxx> wrote:

> This clean up is suggested by Ingo.
>
> It firstly fix the confusions in mm layout tables by unifying
> each memory region description in the consistent style.
>
> Secondly take the KASLR words out of the mm layout tables to make
> it as a separate section to only list mm layout in non-KASLR case.
> Then add KASLR document at the end of mm.txt.
>
> Meanwhile update description about KERNEL_IMAGE_SIZE in
> arch/x86/include/asm/page_64_types.h .
>
> v2->v3:
> Ingo helped to prettify the patch log and code comment, repost them
> after updating accordign to Ingo's suggestions.
>
> v1->v2:
>
> Resend v2 since some typo and incorrect descriptions found in v1 post.
>
> Baoquan He (3):
> x86/KASLR: Update KERNEL_IMAGE_SIZE description
> x86/mm/doc: Clean up the memory region layout descriptions
> x86/doc/kaslr.txt: Create a separate part of document abourt KASLR at
> the end of file

Thanks, patches #1 and #2 are looking good and I'll apply them with some minor fixes, and I'll
comment about patch #3 separately.

I also wrote a larger patch enhancing the descriptions some more, I'll send that separately.

Thanks,

Ingo