Re: [PATCH v1 1/2] x86/cpufeature: Add facility to match microcode revisions

[Thomas Gleixner]

On Sat, 6 Oct 2018, Andi Kleen wrote:
> On Sat, Oct 06, 2018 at 04:14:54PM +0200, Thomas Gleixner wrote:
> > On Fri, 5 Oct 2018, Andi Kleen wrote:
> > > +/*
> > > + * Match specific microcodes or steppings.
> > 
> > What means microcodes or steppings? If you mean microcode revisions then
> > please spell it out and use it all over the place. steppings is confusing
> > at best as its associated to the CPU stepping.
> 
> The matcher can be used to match specific hardware steppings by setting
> the min/max_ucode to 0 or specific microcode revisions 
> (which are associated with steppings)

I can see your point, but calling x86_match_ucode() to match the stepping
of a CPU is really not intuitive. Can we please have functions and data
structures which have a clear purpose and are not overloaded in obscure
ways?

Thanks,

	tglx