Re: [PATCH v9 04/10] x86: refcount: prevent gcc distortions

From: Nadav Amit
Date: Sun Oct 07 2018 - 22:17:22 EST


at 2:31 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:

>
> * Nadav Amit <namit@xxxxxxxxxx> wrote:
>
>>> Are you using defconfig or a reasonable distro-config for your tests?
>>
>> I think it is best to take the kernel and run localyesconfig for testing.
>
> Ok, agreed - and this makes the numbers you provided pretty representative.
>
> Good - now that all of my concerns were addressed I'd like to merge the remaining 3 patches as
> well - but they are conflicting with ongoing x86 work in tip:x86/core. The extable conflict is
> trivial, the jump-label conflict a bit more involved.
>
> Could you please pick up the updated changelogs below and resolve the conflicts against
> tip:master or tip:x86/build and submit the remaining patches as well?

For the record, I summarized my analysis of the poor function inlining
decisions in Linux in the following blog-post:

https://nadav.amit.zone/blog/linux-inline

Regards,
Nadav