Re: [PATCH v2] dma-debug: Check for drivers mapping invalid addresses in dma_map_single()

From: Stephen Boyd
Date: Mon Oct 08 2018 - 00:32:35 EST


Quoting Robin Murphy (2018-10-02 07:01:42)
> On 01/10/18 22:53, Stephen Boyd wrote:
> > diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
> > index d23fc45c8208..99ccba66c06a 100644
> > --- a/include/linux/dma-mapping.h
> > +++ b/include/linux/dma-mapping.h
> > @@ -231,6 +231,7 @@ static inline dma_addr_t dma_map_single_attrs(struct device *dev, void *ptr,
> > dma_addr_t addr;
> >
> > BUG_ON(!valid_dma_direction(dir));
> > + debug_dma_check_single(dev, ptr, size);
>
> Ahem...
>
> With that (and below) fixed so that it actually compiles,
>
> Reviewed-by: Robin Murphy <robin.murphy@xxxxxxx>

Thanks for checking! ;)