Re: [PATCH v3 5/6] parisc: wire up rseq system call

From: Firoz Khan
Date: Mon Oct 08 2018 - 01:52:56 EST


Hi Helge,

On Mon, 8 Oct 2018 at 11:11, Helge Deller <deller@xxxxxx> wrote:
>
> On 08.10.2018 07:16, Firoz Khan wrote:
> > Signed-off-by: Firoz Khan <firoz.khan@xxxxxxxxxx>
> > ---
> > arch/parisc/kernel/syscalls/syscall.tbl | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/parisc/kernel/syscalls/syscall.tbl b/arch/parisc/kernel/syscalls/syscall.tbl
> > index 4e85293..4334bb7 100644
> > --- a/arch/parisc/kernel/syscalls/syscall.tbl
> > +++ b/arch/parisc/kernel/syscalls/syscall.tbl
> > @@ -349,4 +349,5 @@
> > 347 common preadv2 sys_preadv2 compat_sys_preadv2
> > 348 common pwritev2 sys_pwritev2 compat_sys_pwritev2
> > 349 common statx sys_statx
> > -350 common io_pgetevents sys_io_pgetevents compat_sys_io_pgetevents
> > \ No newline at end of file
> > +350 common io_pgetevents sys_io_pgetevents compat_sys_io_pgetevents
> > +351 common rseq sys_rseq compat_sys_rseq
>
> You can't add the rseq syscall for parisc yet.
> It needs additional code in the kernel for parisc which hasn't been tested yet.
> See my initial untested patch at https://patchwork.kernel.org/patch/10495209/

Thanks for your update!

When I compiled the kernel I got below warnings.

<stdin>:696:2: warning: #warning syscall nfsservctl not implemented [-Wcpp]
<stdin>:1335:2: warning: #warning syscall rseq not implemented [-Wcpp]

I added an IGNORE entry nfsservctl in script/checksyscalls.sh because this
syscall is gone. But we definitely have to keep rseq entry on parisc
architecture.

I can ignore this patch currently as your patch not yet tested.

FYI, I have merged the system call table files based on our previous
discussions.
Please comment on that.

I would appreciate if you can perform a boot test without this patch
on the actual
platform.

Firoz

>
> Helge