Re: [PATCH v2 1/1] atmel_lcdfb: support native-mode display-timings

From: Bartlomiej Zolnierkiewicz
Date: Mon Oct 08 2018 - 06:41:18 EST



On 08/25/2018 08:23 PM, Sam Ravnborg wrote:
> When a device tree set a display-timing using native-mode
> then according to the bindings doc this should:
>
> native-mode:
> The native mode for the display, in case multiple
> modes are provided.
> When omitted, assume the first node is the native.
>
> The atmel_lcdfb used the last timing subnode and did not
> respect the timing mode specified with native-mode.
>
> Introduce use of of_get_videomode() which allowed
> a nice simplification of the code while also
> added support for native-mode.
>
> As a nice side-effect this fixes a memory leak where the
> data used for timings and the display_np was not freed.
>
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>

Patch queued for 4.20, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics