Re: [PATCH v11 2/3]: perf record: enable asynchronous trace writing

[Jiri Olsa]

On Mon, Oct 08, 2018 at 09:17:11AM +0300, Alexey Budankov wrote:

SNIP

> -
> +#ifdef HAVE_AIO_SUPPORT
> +	lseek(trace_fd, off, SEEK_SET);
> +#endif
>  	/*
>  	 * Mark the round finished in case we wrote
>  	 * at least one event.
> @@ -650,6 +799,9 @@ record__switch_output(struct record *rec, bool at_exit)
>  	/* Same Size:      "2015122520103046"*/
>  	char timestamp[] = "InvalidTimestamp";
>  
> +#ifdef HAVE_AIO_SUPPORT
> +	record__mmap_read_sync(rec);
> +#endif

same, please define the record__mmap_read_sync dummy
so we can skip that #ifdef #endif

>  	record__synthesize(rec, true);
>  	if (target__none(&rec->opts.target))
>  		record__synthesize_workload(rec, true);
> @@ -1157,6 +1309,10 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)
>  		record__synthesize_workload(rec, true);
>  
>  out_child:
> +
> +#ifdef HAVE_AIO_SUPPORT
> +	record__mmap_read_sync(rec);
> +#endif

ditto

thanks,
jirka

SNIP