Re: [PATCH 1/6] dt-bindings: phy: am654-mmc-phy: Document new phy bindings

From: Ulf Hansson
Date: Mon Oct 08 2018 - 07:30:39 EST


[...]

> +Host controller node:
> +
> + sdhci1: sdhci@0 {
> + compatible = "ti,am654-sdhci-5.1";
> + reg = <0x0 0x1000>;
> + power-domains = <&k3_pds 48>;
> + clocks = <&k3_clks 48 0>, <&k3_clks 48 1>;
> + clock-names = "clk_ahb", "clk_xin";
> + interrupts = <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>;
> + clock-output-names = "mmc_cardclck";

mmc_cardclk

> + #clock-cells = <0>;
> + phys=<&mmc_phy1>;
> + phy-names = "phy_arasan";
> + status = "disabled";
> + };
> --
> 2.18.0
>

Besides the nitpick and the comments from Andrew, this looks good to me.

Kind regards
Uffe