Am 05.10.2018 um 10:38 schrieb Guenter Roeck:
On 10/05/2018 01:14 AM, Koenig, Christian wrote:
Am 04.10.2018 um 20:52 schrieb Guenter Roeck:
Hi,
On Fri, Sep 14, 2018 at 06:05:52PM +0800, Peng Hao wrote:
drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:Was there any feedback on this patch ? The problem does affect us,
ÂÂÂÂÂ In function âgmc_v8_0_process_interruptâ:
drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:1447:10:
ÂÂÂÂÂ warning: missing braces around initializer [-Wmissing-braces]
Signed-off-by: Peng Hao <peng.hao2@xxxxxxxxxx>
and we'll need a fix.
Well as discussed using "{ { 0 } }" is as wrong as using "{ 0 }".
Ah, sorry, I must have missed the discussion.
It is for sure not the best solution, but at least it compiles, and it seems
to be proliferating.
Yeah, and exactly that's the problem. As the discussion showed "{ { 0 } }" is buggy because it tells the compiler to only initialize the first member of the structure, but not all of it.
That is incorrect and rather dangerous cause it can lead to unforeseen results and should probably trigger a warning.
$ git grep "{ *{ *0 *} *}" | wc
ÂÂÂ 144ÂÂÂ 1180ÂÂ 11802
$ git grep "{ *{ *0 *} *}" drivers/gpu/drm/amd/ | wc
ÂÂÂÂ 50ÂÂÂÂ 459ÂÂÂ 5239
We should either use only "{ }" or even better make nails with heads and
use memset().
I'd rather leave it up to the compiler to decide what is most efficient.
And I would rather prefer to have a working driver :)