Re: [PATCH] x86/defconfig: Enable CONFIG_USB_XHCI_HCD

From: Randy Dunlap
Date: Mon Oct 08 2018 - 11:55:57 EST


On 10/8/18 8:20 AM, Alan Stern wrote:
> On Mon, 8 Oct 2018, Greg Kroah-Hartman wrote:
>
>> On Mon, Oct 08, 2018 at 12:32:23PM +0200, Adam Borowski wrote:
>>> A spanking new machine I just got has all but one USB ports wired as 3.0.
>>> Booting defconfig resulted in no keyboard or mouse, which was pretty
>>> uncool. Let's enable that -- USB3 is ubiquitous rather than an oddity.
>>> As 'y' not 'm' -- recovering from initrd problems needs a keyboard.
>>>
>>> Signed-off-by: Adam Borowski <kilobyte@xxxxxxxxxx>
>>> ---
>>> arch/x86/configs/x86_64_defconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>> defconfig for x86 actually still works? That's amazing in itself :)
>>
>>> diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig
>>> index e32fc1f274d8..ac9ae487cfeb 100644
>>> --- a/arch/x86/configs/x86_64_defconfig
>>> +++ b/arch/x86/configs/x86_64_defconfig
>>> @@ -243,6 +243,7 @@ CONFIG_USB_HIDDEV=y
>>> CONFIG_USB=y
>>> CONFIG_USB_ANNOUNCE_NEW_DEVICES=y
>>> CONFIG_USB_MON=y
>>> +CONFIG_USB_XHCI_HCD=y
>>> CONFIG_USB_EHCI_HCD=y
>>> CONFIG_USB_EHCI_TT_NEWSCHED=y
>>> CONFIG_USB_OHCI_HCD=y
>>
>> You can probably turn ehci and ohci off if you have xhci in the
>> "default" system now.
>
> Heh. My office PC has both EHCI and xHCI controllers, but it uses xHCI
> _only_ for SuperSpeed devices, and only on some of the ports. Not a
> combination I have heard of anywhere else. Enabling xHCI without EHCI
> on that computer would be a bad idea. :-)

Yeah, I have some mixed HCD usages as well.

--
~Randy