Re: [PATCH v4 1/3] mm: get_user_pages: consolidate error handling

[Andrew Morton]

On Mon,  8 Oct 2018 14:16:21 -0700 john.hubbard@xxxxxxxxx wrote:

> An upcoming patch requires a way to operate on each page that
> any of the get_user_pages_*() variants returns.
> 
> In preparation for that, consolidate the error handling for
> __get_user_pages(). This provides a single location (the "out:" label)
> for operating on the collected set of pages that are about to be returned.
> 
> As long every use of the "ret" variable is being edited, rename
> "ret" --> "err", so that its name matches its true role.
> This also gets rid of two shadowed variable declarations, as a
> tiny beneficial a side effect.

Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

`i' is a pretty crappy identifier as well, but we'll live.