Re: [PATCH 4.18 000/168] 4.18.13-stable review

[Andre Tomt]

On 09. okt. 2018 11:21, Greg Kroah-Hartman wrote:
> On Tue, Oct 09, 2018 at 05:21:31AM +0200, Andre Tomt wrote:
> > On 08. okt. 2018 20:29, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 4.18.13 release.
> > > There are 168 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> >
> >    CC [M]  net/ipv4/netfilter/nf_conntrack_proto_icmp.o
> > net/ipv4/netfilter/nf_conntrack_proto_icmp.c:373:3: error: âconst struct
> > nf_conntrack_l4protoâ has no member named âctnl_timeoutâ; did you mean
> > âget_timeoutsâ?
> >    .ctnl_timeout  = {
> >     ^~~~~~~~~~~~
> >     get_timeouts
> >
> > The problematic patch is:> netfilter-conntrack-timeout-interface-depend-on-config_nf_conntrack_timeout.patch
> >
> > The stuff the commit message talks about seems like it was added in
> > 4.19-rc1, so this should not go into stable.
> >
> > Kernel builds fine with this one patch reverted.
>
> So you have CONFIG_NF_CT_NETLINK_TIMEOUT enabled but not
> CONFIG_NF_NETLINK_TIMEOUT?  Looks like we just need to modify the .h
> file to fix this up properly, right?

Adding Pablo to the thread as I dont know

> This isn't showing up in my build tests as that configuration seems a
> bit odd to me.

I think you meant CONFIG_NF_CONNTRACK_TIMEOUT instead of 
CONFIG_NF_NETLINK_TIMEOUT?

This is the configuration:
CONFIG_NF_CONNTRACK_TIMEOUT=y
# CONFIG_NF_CT_NETLINK_TIMEOUT is not set