Re: [PATCH 1/3] lib/vsprintf: Prepare for more general use of ptr_to_id()

[Geert Uytterhoeven]

Hi Petr,

On Tue, Oct 9, 2018 at 3:56 PM Petr Mladek <pmladek@xxxxxxxx> wrote:
> On Mon 2018-10-08 16:37:29, Geert Uytterhoeven wrote:
> > On Mon, Oct 8, 2018 at 4:25 PM Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > > On Mon, Oct 08, 2018 at 01:05:02PM +0200, Geert Uytterhoeven wrote:
> > > >   - Make the ptr argument const, to avoid adding casts in future
> > > >     callers,
> > >
> > > >   - Add a forward declaration, to avoid moving large blocks of code.
> > >
> > > How big it would be? ptr_to_id() itself plus...
> >
> > ... all the randomization helpers.
> > And ptr_to_id() needs pointer_string(), string(), widen_string(), number(),
> > and move_right().
> >
> > 118 insertions(+), 120 deletions(-)
> >
> > Is that acceptable?
>
> Yes, it is acceptable. And my feeling is that it is the preferred
> solution is kernel because it helps to keep the code cleaner
> in the long term.
>
> I am for moving the code if there is no cyclic dependency.

OK, will do so for v2.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds