Re: [PATCH] samples: disable CONFIG_SAMPLES for UML

[Masahiro Yamada]

On Tue, Sep 18, 2018 at 12:59 PM Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:
>
> Some samples require headers installation, so commit 3fca1700c4c3
> ("kbuild: make samples really depend on headers_install") added
> such dependency in the top Makefile.  However, UML fails to build
> with CONFIG_SAMPLES=y because UML does not support headers_install.
>
> Fixes: 3fca1700c4c3 ("kbuild: make samples really depend on headers_install")
> Reported-by: Kees Cook <keescook@xxxxxxxxxxxx>
> Cc: David Howells <dhowells@xxxxxxxxxx>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> ---

I did not get any more comment.
I applied to linux-kbuild/fixes.



>
>  samples/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/samples/Kconfig b/samples/Kconfig
> index bd133ef..ad1ec701 100644
> --- a/samples/Kconfig
> +++ b/samples/Kconfig
> @@ -1,5 +1,6 @@
>  menuconfig SAMPLES
>         bool "Sample kernel code"
> +       depends on !UML
>         help
>           You can build and test sample kernel code here.
>
> --
> 2.7.4
>


-- 
Best Regards
Masahiro Yamada