Re: [PATCH 4.18 000/168] 4.18.13-stable review

[Pablo Neira Ayuso]

On Tue, Oct 09, 2018 at 05:18:28PM +0200, Pablo Neira Ayuso wrote:
> On Tue, Oct 09, 2018 at 01:33:39PM +0200, Andre Tomt wrote:
> > On 09. okt. 2018 11:21, Greg Kroah-Hartman wrote:
> > > On Tue, Oct 09, 2018 at 05:21:31AM +0200, Andre Tomt wrote:
> > > > On 08. okt. 2018 20:29, Greg Kroah-Hartman wrote:
> > > > > This is the start of the stable review cycle for the 4.18.13 release.
> > > > > There are 168 patches in this series, all will be posted as a response
> > > > > to this one.  If anyone has any issues with these being applied, please
> > > > > let me know.
> > > > 
> > > >    CC [M]  net/ipv4/netfilter/nf_conntrack_proto_icmp.o
> > > > net/ipv4/netfilter/nf_conntrack_proto_icmp.c:373:3: error: âconst struct
> > > > nf_conntrack_l4protoâ has no member named âctnl_timeoutâ; did you mean
> > > > âget_timeoutsâ?
> > > >    .ctnl_timeout  = {
> > > >     ^~~~~~~~~~~~
> > > >     get_timeouts
> > > > 
> > > > The problematic patch is:> netfilter-conntrack-timeout-interface-depend-on-config_nf_conntrack_timeout.patch
> > > > 
> > > > The stuff the commit message talks about seems like it was added in
> > > > 4.19-rc1, so this should not go into stable.
> > > > 
> > > > Kernel builds fine with this one patch reverted.
> > > 
> > > So you have CONFIG_NF_CT_NETLINK_TIMEOUT enabled but not
> > > CONFIG_NF_NETLINK_TIMEOUT?  Looks like we just need to modify the .h
> > > file to fix this up properly, right?
> > 
> > Adding Pablo to the thread as I dont know
> > 
> > > This isn't showing up in my build tests as that configuration seems a
> > > bit odd to me.
> > 
> > I think you meant CONFIG_NF_CONNTRACK_TIMEOUT instead of
> > CONFIG_NF_NETLINK_TIMEOUT?
> > 
> > This is the configuration:
> > CONFIG_NF_CONNTRACK_TIMEOUT=y
> > # CONFIG_NF_CT_NETLINK_TIMEOUT is not set
> 
> upstream commit a874752a10da113f513980e28f562d946d3f829d depends on:
> 
> commit 6c1fd7dc489d9bf64196f5b0fa33e059f64460c8
> Author: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
> Date:   Tue Aug 7 17:14:15 2018 +0200
> 
>     netfilter: cttimeout: decouple timeout policy from nfnetlink_cttimeout object
> 
> So I would suggest to keep it back / not place it 4.18.x stable.

Hm, actually, a874752a10da113f513980e28f562d946d3f829 depends on:

commit ad83f2a9ce37a264202f48f4fd8889ee9056b703
Author: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
Date:   Tue Aug 7 17:14:19 2018 +0200

    netfilter: remove ifdef around cttimeout in struct nf_conntrack_l4proto

Not the one I mentioned above.