Re: [RFC] perf tools: Wrong filter_band* values in json calculation"

From: Andi Kleen
Date: Tue Oct 09 2018 - 17:19:35 EST


On Tue, Oct 09, 2018 at 12:01:44PM +0200, Jiri Olsa wrote:
> On Wed, Oct 03, 2018 at 07:45:50AM -0700, Andi Kleen wrote:
> > > note there's couple of changes that actually changed
> > > the number completely, like:
> > >
> > > - "Filter": "edge=1,filter_band2=4000",
> > > + "Filter": "edge=1,filter_band2=30",
> >
> > Thanks. Looks good. I'll fix the scripts to generate the uncore events.
>
> hi,
> any idea when you could post an update for this?

Can just use your patch for the existing event lists. You can add

Acked-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

I was mainly worried about future updates, but it doesn't seem to be a problem.

-Andi