Re: [PATCH 4.4 093/113] pinctrl: msm: Really mask level interrupts to prevent latching

From: Nathan Chancellor
Date: Wed Oct 10 2018 - 03:53:44 EST


On Wed, Oct 10, 2018 at 09:12:58AM +0200, Linus Walleij wrote:
> On Tue, Oct 9, 2018 at 8:33 AM Nathan Chancellor
> <natechancellor@xxxxxxxxx> wrote:
>
> > Sigh, sorry, I caught this after I sent my initial all good email but
> > this commit breaks NFC on my Pixel 2 XL (toggle becomes greyed out and
> > apps that want to use it ask to enable it). I can't say why, I'm more
> > than happy to debug but I'm assuming it's some voodoo that Qualcomm has
> > done out of tree. I'll leave it up to you how to proceed given that I
> > can't run mainline :(
>
> Which NFC driver is this?
> Just want to make sure it looks sane.
>
> Yours,
> Linus Walleij

Hi Linus and Bjorn,

These two files should be it I believe:
https://android.googlesource.com/kernel/msm/+/android-9.0.0_r0.22/drivers/nfc/nq-nci.c
https://android.googlesource.com/kernel/msm/+/android-9.0.0_r0.22/drivers/nfc/ese/pn81a.c

Sorry I didn't get around to digging into this further today, I will try
to get to it in the morning.

Cheers,
Nathan