Re: [PATCH 2/2] target: Fix target_wait_for_sess_cmds breakage with active signals
From: Peter Zijlstra
Date: Wed Oct 10 2018 - 04:44:00 EST
On Wed, Oct 10, 2018 at 03:23:10AM +0000, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
>
> With the addition of commit 00d909a107 in v4.19-rc, it incorrectly assumes no
> signals will be pending for task_struct executing the normal session shutdown
> and I/O quiesce code-path.
>
> For example, iscsi-target and iser-target issue SIGINT to all kthreads as
> part of session shutdown. This has been the behaviour since day one.
Not knowing much context here; but does it make sense for those
kthreads to handle signals, ever? Most kthreads should be fine with
ignore_signals().