Re: [PATCH v2 0/3] lib/vsprintf: Hash remaining raw addresses

[Andy Shevchenko]

On Thu, Oct 11, 2018 at 10:42:46AM +0200, Geert Uytterhoeven wrote:
> 	Hi all,
> 
> There are still two format specifiers that print unhanced kernel
> addresses, potentially leaking sensitive information regarding the
> kernel layout in memory.
> 
> This patch series fixes this by printing hashed addresses instead.

Looks nice!

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

>     
> Changes compared to v1:
>   - Get rid of the forward declaration for ptr_to_id(),
>   - Add Reviewed-by.
> 
> Thanks!
> 
> Geert Uytterhoeven (3):
>   lib/vsprintf: Prepare for more general use of ptr_to_id()
>   lib/vsprintf: Hash legacy clock addresses
>   lib/vsprintf: Hash printed address for netdev bits fallback
> 
>  Documentation/core-api/printk-formats.rst |   5 +-
>  lib/vsprintf.c                            | 216 +++++++++++-----------
>  2 files changed, 110 insertions(+), 111 deletions(-)
> 
> -- 
> 2.17.1
> 
> Gr{oetje,eeting}s,
> 
> 						Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> 							    -- Linus Torvalds

-- 
With Best Regards,
Andy Shevchenko