Re: REGRESSION: [PATCH v5 3/3] gpiolib: Show correct direction from the beginning

From: Marcel Ziswiler
Date: Fri Oct 12 2018 - 05:35:07 EST


On Fri, 2018-10-12 at 11:08 +0200, Linus Walleij wrote:
> On Fri, Oct 12, 2018 at 11:00 AM Marcel Ziswiler
> <marcel.ziswiler@xxxxxxxxxxx> wrote:
> > On Fri, 2018-10-05 at 08:53 +0200, Ricardo Ribalda Delgado wrote:
> > > Current code assumes that the direction is input if
> > > direction_input
> > > function is set.
> > > This might not be the case on GPIOs with programmable direction.
> >
> > Unfortunately, this breaks at least Apalis T30 and Apalis TK1.
> > Enabling
> > earlycon reveals the following:
>
> Does this (just applied) patch fix the issue?
> https://marc.info/?l=linux-kernel&m=153932470412013&w=2

Yes, that cuts it. Thanks!

> Yours,
> Linus Walleij