Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only
From: Andy Shevchenko
Date: Fri Oct 12 2018 - 09:58:54 EST
On Fri, Oct 12, 2018 at 1:45 PM Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxx> wrote:
>
> On Fri, Oct 12, 2018 at 11:39:15AM +0100, Jon Hunter wrote:
> > We had the same situation for Tegra124 Jetson TK1 but I don't think that
> > adding a pseudo intermediate regulator is cleaner. If the GPIO controls
> > more than one regulator, I don't see why is it necessary to change the
> > DT. There are several other people reporting the same problem with
> > various different boards. So this does seem to be a common usage.
>
> Given that DT describes the hardware, not the software implementation,
> it must not change just because we move from GPIO numbers to GPIO
> descriptors.
>
> The existing DT description is reasonable, and introducing ficticious
> regulators in DT to work around the implementation is not reasonable.
If there is no way to detect shared use of GPIO line for regulators
(*) from current DT description, DT description should be updated to
reflect, yes, hardware.
(*) Not familiar with the guts of DT descriptive language, don't know
if there are some ways to do a such without additional flags or so.
--
With Best Regards,
Andy Shevchenko