Re: [PATCH v3 09/11] arch/x86: Introduce new config parameter AMD_QOS

[Moger, Babu]

Boris,

On 10/11/2018 05:02 PM, Borislav Petkov wrote:
> On Thu, Oct 11, 2018 at 08:33:35PM +0000, Moger, Babu wrote:
>> Introduces the new config parameter AMD_QOS. This parameter will be
>> used to enable cache and memory bandwidth allocation and monitoring
>> features on AMD processors. This will enable common config parameter
>> RESCTRL if selected.
>>
>> Signed-off-by: Babu Moger <babu.moger@xxxxxxx>
>> ---
>>  arch/x86/Kconfig | 17 ++++++++++++++++-
>>  1 file changed, 16 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index 91a703ebdc04..5cef55935a5a 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -458,9 +458,24 @@ config INTEL_RDT
>>  
>>  	  Say N if unsure.
>>  
>> +config AMD_QOS
>> +	bool "AMD Quality of Service support"
>> +	default n
>> +	depends on X86 && CPU_SUP_AMD
> 
> Why the X86 dependency too? CPU_SUP_AMD is x86-specific and indirectly
> implies X86, I'd say.

That is correct. CPU_SUP_AMD implicitly means x86.
To be more specific, I will change it to
"depends on X86_64 && CPU_SUP_AMD" as this feature is for X86_64 only.
Thanks