Re: [PATCH v3 3/3] usb: typec: tcpm: charge current handling for sink during hard reset
From: Rob Herring
Date: Fri Oct 12 2018 - 10:49:02 EST
On Mon, 1 Oct 2018 12:45:01 -0700, Badhri Jagan Sridharan wrote:
> During the initial connect to a non-pd port, sink would hard reset
> twice before deeming that the port partner is non-pd. TCPM sets the
> the charge path to false during the hard reset. This causes unnecessary
> connects/disconnects of charge path and makes port take longer to
> charge from the non-pd ports. Avoid this by not setting the charge path
> to false unless the partner has already identified to be pd capable.
>
> When partner is a pd port, set the charge path to false in
> SNK_HARD_RESET_SINK_OFF. Set the current limits to default value based
> of CC pull up and resume the charge path when port enters
> SNK_HARD_RESET_SINK_ON.
>
> Signed-off-by: Badhri Jagan Sridharan <badhri@xxxxxxxxxx>
>
> --------
> Changes in V3:
> Rebase on top of usb-next
>
> Changes in V2:
> Based on feedback of jackp@xxxxxxxxxxxxxx
> - vsafe_5v_hard_reset flag from tcpc_config is removed
> - Patch only differentiates between pd port partner and non-pd port
> partner
>
> V1 version of the patch is here:
> https://lkml.org/lkml/2018/9/14/11
> ---
> drivers/usb/typec/tcpm/tcpm.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@xxxxxxxxxx>