Re: [PATCH] KEYS: trusted: fix -Wvarags warning

[Denis Kenzior]

Hi James,

> > So instead of having unsigned char h3, can't we simply have bool h3
> > or unsigned int h3?
>
> Given the ambiguity in the standards, the safe thing that will work for
> all time and all potential compilers is a char *

All right.  You state this with certainty, but I'd still like you to 
educate me why?

From the links provided in the patch it seems that one cannot pass 
char/float/short to va_start().  Fair enough.  So if we make h3 an 
unsigned int, the issue goes away, no?

 int TSS_authhmac(unsigned char *digest, const unsigned char *key,
                        unsigned int keylen, unsigned char *h1,
-                       unsigned char *h2, unsigned char h3, ...);
+                       unsigned char *h2, unsigned int h3, ...);

Regards,
-Denis