Re: [RFC][PATCH] x86: ptrace: Add function argument access API

From: Andy Lutomirski
Date: Fri Oct 12 2018 - 14:21:44 EST


On Fri, Oct 12, 2018 at 9:26 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
>
> Anyone have any issues with this patch?
>

I'm conceptually okay with it. That being said,
regs_within_kernel_stack(), which you're indirectly using, is
off-by-a-few. And updating it to use probe_kernel_read() might be
nice for robustness.

--Andy