Re: [PATCH 1/6] mm: get_user_pages: consolidate error handling

[John Hubbard]

On 10/11/18 11:30 PM, Balbir Singh wrote:
> On Thu, Oct 11, 2018 at 11:00:09PM -0700, john.hubbard@xxxxxxxxx wrote:
> > From: John Hubbard <jhubbard@xxxxxxxxxx>
> >
> > An upcoming patch requires a way to operate on each page that
> > any of the get_user_pages_*() variants returns.
> >
> > In preparation for that, consolidate the error handling for
> > __get_user_pages(). This provides a single location (the "out:" label)
> > for operating on the collected set of pages that are about to be returned.
> >
> > As long every use of the "ret" variable is being edited, rename
> > "ret" --> "err", so that its name matches its true role.
> > This also gets rid of two shadowed variable declarations, as a
> > tiny beneficial a side effect.
> >
> > Reviewed-by: Jan Kara <jack@xxxxxxx>
> > Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx>
> > ---
>
> Looks good, might not be needed but
> Reviewed-by: Balbir Singh <bsingharora@xxxxxxxxx>

Thanks for the review, very good to have another set of eyes on
this one.

--
thanks,
John Hubbard
NVIDIA