Re: [PATCH v4 5/6] parisc: wire up rseq system call
From: Firoz Khan
Date: Sat Oct 13 2018 - 01:42:29 EST
Hi Arnd, Helge,
On Sat, 13 Oct 2018 at 01:53, Helge Deller <deller@xxxxxx> wrote:
>
> On 12.10.2018 13:52, Arnd Bergmann wrote:
> > On Fri, Oct 12, 2018 at 12:16 PM Firoz Khan <firoz.khan@xxxxxxxxxx> wrote:
> >>
> >> Hi Arnd,
> >>
> >> On Fri, 12 Oct 2018 at 15:26, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> >>>
> >>> On Fri, Oct 12, 2018 at 11:45 AM Firoz Khan <firoz.khan@xxxxxxxxxx> wrote:
> >>>>
> >>>> Wire up rseq system call requires an architecture specific
> >>>> implementation as it not present now.
> >>>>
> >>>> Signed-off-by: Firoz Khan <firoz.khan@xxxxxxxxxx>
> >>>
> >>> Didn't we conclude that this should be skipped?
> >>
> >> Helge told "I prefer to keep the warning for rseq for now.
> >> It reminds me that we still may want the rseq syscall.
> >> If the warning is a problem, you may simply add the __IGNORE_rseq define."
> >>
> >> I chose this option; I feel it looks clean
> >> "# rseq requires an architecture specific implementation" in syscall.tbl
> >> hopefully remind him to add rseq syscall implementation in this architecture.
> >
> > But he said he wants the warning instead.
>
> Correct.
> Firoz, please simply drop this patch completely.
> That way one will see generated warnings about the missing rseq (which is what
> we want).
Sure. will do!
Firoz
>
> Thanks,
> Helge