Re: ubifs: WARNINGs

From: Richard Weinberger
Date: Sat Oct 13 2018 - 04:21:57 EST


Randy,

On Sat, Oct 13, 2018 at 3:48 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> Hi,
>
> Linux 4.19-rc7, x86_64 laptop.
>
> I don't have an ubifs filesystem. When I just modprobe ubifs and then
> rmmod ubifs, I get 2 WARNINGs from these 2 lines:
>
> static void __exit ubifs_exit(void)
> {
> WARN_ON(list_empty(&ubifs_infos));
> WARN_ON(atomic_long_read(&ubifs_clean_zn_cnt) == 0);
>
> Is this normal/expected?

Nah, in -rc1 I rewrote all UBIFS assert code and these two are a corner case.
I've messed up the logic, ubifs_assert(exp) is WARN_ON(!exp).
Patch sent, would be great if you could give it a try.

--
Thanks,
//richard