Re: Bug introduced in the of_get_named_gpiod_flags function.

From: Linus Walleij
Date: Sat Oct 13 2018 - 12:24:05 EST


On Sat, Oct 13, 2018 at 5:53 PM wzabolot@xxxxxxxxxxxxxxxxxxxxxxx
<wzabolot@xxxxxxxxxxxxxxxxxxxxxxx> wrote:

> The question is, if there may be any other in-tree GPIO controller
> driver that does not initialize those flags?

So as I said, I looked over them and they all initialize
their flags.

> Anyway the current situation is somehow dangerous.

Not very dangerous compared to much other kernel code.

> Maybe the best solution would be to initialize the automatic variable in
> the of_find_gpio?

Patches welcom, make sure they are tested with mainline
code and drivers.

Yours.
Linus Walleij