Re: [PATCH v4 3/6] parisc: add system call table generation support

[Rolf Eike Beer]

Firoz Khan wrote:
> Hi Rolf,
> 
> On Fri, 12 Oct 2018 at 17:37, Rolf Eike Beer <eike-kernel@xxxxxxxxx> wrote:
> > Firoz Khan wrote:

> > > +prefix="$4"
> > > +offset="$5"
> > > +
> > > +fileguard=_UAPI_ASM_PARISC_`basename "$out" | sed \
> > > +    -e 'y/abcdefghijklmnopqrstuvwxyz/ABCDEFGHIJKLMNOPQRSTUVWXYZ/' \
> > > +    -e 's/[^A-Z0-9_]/_/g' -e 's/__/_/g'`
> > > +grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | (
> > > +    echo "#ifndef ${fileguard}"
> > > +    echo "#define ${fileguard}"
> > > +    echo ""
> > > +
> > > +    nxt=0
> > > +    while read nr abi name entry compat ; do
> > > +     if [ -z "$offset" ]; then
> > > +         echo -e "#define __NR_${prefix}${name}\t$nr"
> > 
> > This mixed indentation with both tabs and spaces is a bit messy.
> 
> Is this what you suggested?
> -           echo -e "#define __NR_${prefix}${name}\t$nr"
> +           echo "#define __NR_${prefix}${name} $nr"

No, this was actually only about the script itself. Looks like your editor has 
tab-width 8 and indentation 4 or so.

Eike

Attachment: signature.asc
Description: This is a digitally signed message part.