Re: [PATCH v4 1/2] Bluetooth: Add device_get_bd_address()

[Matthias Kaehlcke]

Hi Marcel,

please let me know if any changes are needed to get this patch applied
to bluetooth-next.

Thanks

Matthias

On Thu, Oct 04, 2018 at 10:33:38AM -0700, Matthias Kaehlcke wrote:
> On Thu, Sep 27, 2018 at 10:13:05AM -0700, Matthias Kaehlcke wrote:
> > On Thu, Sep 27, 2018 at 12:47:06PM -0400, Sinan Kaya wrote:
> > > On 9/27/2018 12:41 PM, Balakrishna Godavarthi wrote:
> > > >  ÂvoidÂbt_sock_reclassify_lock(structÂsockÂ*sk,ÂintÂproto);
> > > > 
> > > > +intÂdevice_get_bd_address(structÂdeviceÂ*dev,Âbdaddr_tÂ*bd_addr);
> > > 
> > > Maybe change the API name to start with bt_ and get rid of device_?
> > 
> > device_ indicates that we get the BD_ADDR for a 'struct device' and
> > not for e.g. a 'struct fwnode_handle'.
> > 
> > Anyway with this version of the patch fwnode_get_bd_address() has been
> > scrapped and it might never be introduced again, so I'm open to change
> > the name to bt_ if there is a general preference for it.
> 
> Marcel, can you live with this being added to the Bluetooth code base
> instead of property? Also if you'd prefer the function to be named
> bt_get_bd_address() let me know.
> 
> Cheers
> 
> Matthias