Re: Re: [PATCH v1 1/2] sysctl: cap to ULONG_MAX in proc_get_long()

From: Christian Brauner
Date: Mon Oct 15 2018 - 15:32:47 EST


On Mon, Oct 15, 2018 at 9:27 PM Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:
>
> > int kstrtoul_bounded(const char *s, unsigned int base,
> > char **trailing, unsigned long long *res)
>
> NO! The whole point is not have million variants of slightly different
> integer parsing functions.
> Cap it in the sysctl -- noone would care.

(Please keep the CC list when replying.)

Whatever works; I prefer the local strtoul_cap_erange() in kernel/sysctl.c as
well.