Re: [PATCH 2/2] f2fs: update REQ_TIME in f2fs_cross_rename()

From: Chao Yu
Date: Mon Oct 15 2018 - 21:34:19 EST


On 2018/10/16 7:03, Jaegeuk Kim wrote:
> On 10/15, Chao Yu wrote:
>> On 2018/10/5 13:17, Sahitya Tummala wrote:
>>> Update REQ_TIME in the missing path - f2fs_cross_rename().
>>
>> Needs to cover f2fs_rename() as well?
>
> Hi, I've added this in f2fs_rename().

Oh, I see, it looks okay to me now. :)

Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx>

Thanks,

>
> Thanks,
>
>>
>> Thanks,
>>
>>>
>>> Signed-off-by: Sahitya Tummala <stummala@xxxxxxxxxxxxxx>
>>> ---
>>> fs/f2fs/namei.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
>>> index a146327..e37af23 100644
>>> --- a/fs/f2fs/namei.c
>>> +++ b/fs/f2fs/namei.c
>>> @@ -1154,6 +1154,8 @@ static int f2fs_cross_rename(struct inode *old_dir, struct dentry *old_dentry,
>>>
>>> if (IS_DIRSYNC(old_dir) || IS_DIRSYNC(new_dir))
>>> f2fs_sync_fs(sbi->sb, 1);
>>> +
>>> + f2fs_update_time(sbi, REQ_TIME);
>>> return 0;
>>> out_new_dir:
>>> if (new_dir_entry) {
>>>
>
> .
>