Re: [PATCH 2/2] phy: ocelot-serdes: fix out-of-bounds read

From: Kishon Vijay Abraham I
Date: Tue Oct 16 2018 - 04:49:23 EST


Hi,

On Tuesday 16 October 2018 02:16 PM, Gustavo A. R. Silva wrote:
> Hi,
>
> On 10/9/18 9:28 AM, Quentin Schulz wrote:
>> Hi Gustavo,
>>
>> On Tue, Oct 09, 2018 at 12:22:33AM +0200, Gustavo A. R. Silva wrote:
>>> Currently, there is an out-of-bounds read on array ctrl->phys,
>>> once variable i reaches the maximum array size of SERDES_MAX
>>> in the for loop.
>>>
>>> Fix this by changing the condition in the for loop from
>>> i <= SERDES_MAX to i < SERDES_MAX.
>>>
>>
>> Reviewed-by: Quentin Schulz <quentin.schulz@xxxxxxxxxxx>
>>
>
> Friendly ping. Who can you take this?

This can go during the 4.20 -rc cycle.

Thanks
Kishon