Re: [PATCH] staging: iio: adc: Add comments to prevent checks corrections

From: Dan Carpenter
Date: Tue Oct 16 2018 - 08:45:33 EST


On Mon, Oct 15, 2018 at 06:25:21PM -0300, Gabriel Capella wrote:
> This patch adds 3 comments in 2 different files.
> These comments warn to don't correct the checks of type:
> "CHECK: spaces preferred around that '-'"
>
> Signed-off-by: Gabriel Capella <gabriel@xxxxxxxxxxx>
> ---
> drivers/staging/iio/adc/ad7192.c | 1 +
> drivers/staging/iio/adc/ad7280a.c | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index acdbc07fd259..786ace19c240 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -354,6 +354,7 @@ ad7192_show_scale_available(struct device *dev,
> return len;
> }
>
> +/* Do not put spaces around the hyphen. #checkpatch.pl */
> static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available,
> in_voltage-voltage_scale_available,
> 0444, ad7192_show_scale_available, NULL, 0);

No one will read that... :( It has to be on the same line.

regards,
dan carpenter