Re: [PATCH] crypto: inside-secure: safexcel - fix memory allocation

From: Gustavo A. R. Silva
Date: Tue Oct 16 2018 - 15:44:22 EST


Hi all,

On 10/9/18 12:20 AM, Kees Cook wrote:
> On Mon, Oct 8, 2018 at 12:17 PM, Gustavo A. R. Silva
> <gustavo@xxxxxxxxxxxxxx> wrote:
>> The original intention is to allocate space for EIP197_DEFAULT_RING_SIZE
>> *pointers* to struct, so sizeof(priv->ring[i].rdr_req) should be
>> sizeof(*priv->ring[i].rdr_req).
>>
>> Addresses-Coverity-ID: 1473962 ("Sizeof not portable")
>> Fixes: 9744fec95f06 ("crypto: inside-secure - remove request list to improve performance")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>
> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
>


Friendly ping. Who can take this?

Thanks!
--
Gustavo