Re: [PATCH] staging: iio: ad7280a: Lines should not end with a '(' - style
From: Joe Perches
Date: Tue Oct 16 2018 - 19:08:07 EST
(There is a linux-usp@xxxxxxxxxxxxxxxx mailing list
that bounces when I reply, so I removed it from the
On Tue, 2018-10-16 at 19:48 -0300, Giuliano Belinassi wrote:
> Thank you for your review :-).
> Sorry, but I am a newbie on this, and now I am confused about my next
> step. Should I make a v2 based on your changes, or do you want to submit
> your changes?
I wrote that to encourage you to do more than
what checkpatch says.
I just moved code around and reduced duplication.
There are many similar opportunities for code
refactoring in staging.
You could test what I wrote, add a good commit
message with a subject like:
[PATCH V2] staging: iio: ad7280a: Refactor <functionname>
with a commit message that describes the changes and
perhaps shows the object size difference using
$ size <old> <new>
Maybe add a Suggested-by: tag if it pleases you, but
what I did is trivial and I think it's unnecessary.
Are you doing this for a class assignment?