Re: [PATCH -next] advansys: use correct srb_tag in adv_isr_callback

From: Martin K. Petersen
Date: Tue Oct 16 2018 - 21:34:25 EST



Hi Yue Haibing,

> srb_tag = le32_to_cpu(scsiqp->srb_tag);
> - scp = scsi_host_find_tag(boardp->shost, scsiqp->srb_tag);
> + scp = scsi_host_find_tag(boardp->shost, srb_tag);

Maybe I'm missing something, but I don't see where in the code
scsiqp->srb_tag is being converted to le32. srb_tag is beyond the memory
accessed by the controller and thus wouldn't need to be little endian.

--
Martin K. Petersen Oracle Linux Engineering